Set computed flag for 'max_pods_per_node' in google_container_node_pool #2077
Conversation
After upgrading the provider to 1.18 users will notice an unnecessary Terraform plan difference, where the 'max_pods_per_node' parameter will change from 110 to 0. This commit changes the behaviour so that for state that does not have the parameter configured, no changes will be planned.
thevilledev
changed the title
|
Interesting - might that have been set in the console, outside of Terraform? I ask because we're not seeing that behavior in our unit tests. Still, probably a good idea to have it as |
|
@ndmckinley at least in my case all node pools were created in Terraform with version 1.17 of the provider. Also I had a completely new environment from early this week. I noticed the plan difference after upgrading the provider, so I guess it should be reproducible if someone wants to try that. Thanks for merging! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked and limited conversation to collaborators
After upgrading
terraform-provider-googleto version 1.18 users will notice an unnecessary Terraform plan difference in existing node pool configurations. This is caused by a new configuration parametermax_pods_per_nodewhich was introduced in #2038. At the moment it expects end users to explicitly define the parameter value in the configuration or it expects to find it from the existing state. Since neither of these will be found the provider will fallback to default value of 0.Example:
This PR fixes the issue by letting the Google Container API to decide what the value is for existing clusters, which is 110 in this case. If the value is not defined in the Terraform configuration then it won't be used either.